fix(executor): restore tty foreground pgrp for interactive sessions#42
Merged
fix(executor): restore tty foreground pgrp for interactive sessions#42
Conversation
When the sandboxed child was placed in its own process group (#39), it was no longer the tty foreground group, causing SIGTTIN on any tty read and hanging interactive shells. Add TtyForegroundGuard: hands the tty foreground to the child pgrp via tcsetpgrp after spawn (SIGTTOU suppressed during handoff) and restores the original foreground on drop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TtyForegroundGuard: after spawning, hands the tty foreground to the child's pgrp viatcsetpgrp(with SIGTTOU suppressed during the handoff), and restores the original foreground on drop.PgidKillGuard, ensuring the parent reclaims the tty on all exit paths including panics.Test plan
sx onlinein an interactive terminal — shell should accept input without hangingsx offlineand type a command — verify normal interactive behaviorsx -- echo hi(non-interactive) — guard is a no-op, output is correctcargo test— all existing tests pass